netdev - Re: [PATCH v3] xfrm: Reset secpath in xfrm failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190311100927.GJ3758@gauss3.secunet.de>
Date:   Mon, 11 Mar 2019 11:09:27 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Myungho Jung <mhjungk@...il.com>
CC:     Eric Dumazet <eric.dumazet@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] xfrm: Reset secpath in xfrm failure

On Thu, Mar 07, 2019 at 10:23:08AM +0900, Myungho Jung wrote:
> In esp4_gro_receive() and esp6_gro_receive(), secpath can be allocated
> without adding xfrm state to xvec. Then, sp->xvec[sp->len - 1] would
> fail and result in dereferencing invalid pointer in esp4_gso_segment()
> and esp6_gso_segment(). Reset secpath if xfrm function returns error.
> 
> Fixes: 7785bba299a8 ("esp: Add a software GRO codepath")
> Reported-by: syzbot+b69368fd933c6c592f4c@...kaller.appspotmail.com
> Signed-off-by: Myungho Jung <mhjungk@...il.com>

Applied, thanks a lot!