netdev - Re: [PATCH iproute2-next 2/3] ip: bridge: add xstats json support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190312123348.7e8f963b@shemminger-XPS-13-9360>
Date:   Tue, 12 Mar 2019 12:33:48 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        dsa@...ulusnetworks.com
Subject: Re: [PATCH iproute2-next 2/3] ip: bridge: add xstats json support

On Tue, 12 Mar 2019 18:41:27 +0200
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

I like it.

> +			print_u64(PRINT_ANY, "rx_v1", "RX: v1 %llu ",
> +				  mstats->igmp_v1reports[BR_MCAST_DIR_RX]);
> +			print_u64(PRINT_ANY, "rx_v2", "v2 %llu ",
> +				  mstats->igmp_v2reports[BR_MCAST_DIR_RX]);
> +			print_u64(PRINT_ANY, "rx_v3", "v3 %llu\n",
> +				  mstats->igmp_v3reports[BR_MCAST_DIR_RX]);
> +			print_string(PRINT_FP, NULL, "%-16s      ", "");
> +			print_u64(PRINT_ANY, "tx_v1", "TX: v1 %llu ",
> +				  mstats->igmp_v1reports[BR_MCAST_DIR_TX]);
> +			print_u64(PRINT_ANY, "tx_v2", "v2 %llu",
> +				  mstats->igmp_v2reports[BR_MCAST_DIR_TX]);
> +			print_u64(PRINT_ANY, "tx_v3", "v3 %llu\n",
> +				  mstats->igmp_v3reports[BR_MCAST_DIR_TX]);

Maybe the IGMP reports should be shown in JSON as as an array?
Or use "rx_igmpv1"  the tag could be more descriptive