netdev - Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in xsk_socket_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b72bbcca-71b5-7870-a997-d631ebd822cc@iogearbox.net>
Date:   Tue, 12 Mar 2019 21:52:53 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     Magnus Karlsson <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Maciek Fijałkowski 
        <maciejromanfijalkowski@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf v2] libbpf: fix to reject unknown flags in
 xsk_socket__create()

On 03/12/2019 09:02 PM, Andrii Nakryiko wrote:
> On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson
> <magnus.karlsson@...il.com> wrote:
>>
>> On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko
>> <andrii.nakryiko@...il.com> wrote:
>>>
>>> On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson
>>> <magnus.karlsson@...el.com> wrote:
>>>>
>>>> In xsk_socket__create(), the libbpf_flags field was not checked for
>>>> setting currently unused/unknown flags. This patch fixes that by returning
>>>> -EINVAL if the user has set any flag that is not in use at this point
>>>> in time.
>>>>
>>>> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
>>>> Reviewed-by: Andrii Nakryiko <andrii.nakryiko@...il.com>
>>>
>>> Can you please replace email with andriin@...com?
>>
>> Sure, but do I have to spin a v3 for that or can I just resubmit the
>> v2 with your fb.com mail address?
> 
> I'd assume no need for v3.

Will fix it up when applying, thanks!