lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 11 Mar 2019 23:56:24 -0500
From:   Kangjie Lu <kjlu@....edu>
To:     David Miller <davem@...emloft.net>
Cc:     pakki001@....edu, colin.king@...onical.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: fjes: fix potential NULL pointer dereferences



> On Mar 11, 2019, at 6:19 PM, David Miller <davem@...emloft.net> wrote:
> 
> From: Kangjie Lu <kjlu@....edu>
> Date: Mon, 11 Mar 2019 02:10:21 -0500
> 
>> 	adapter->control_wq = alloc_workqueue(DRV_NAME "/control",
>> 					      WQ_MEM_RECLAIM, 0);
>> +	if (!adapter->control_wq) {
>> +		err = -ENOMEM;
>> +		goto err_free_netdev;
>> +	}
> 
> This error path leaks adapter->txrx_wq.

The following code also has an error-handling case: goto err_free_netdev.
Shouldn’t the resource release be in err_free_netdev?

> 

Powered by blists - more mailing lists