netdev - Re: [PATCH v2] net: sh_eth: fix a missing check of of_get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <902bc3a0-94b5-cf00-6b41-f2724744fbe6@cogentembedded.com>
Date:   Tue, 12 Mar 2019 10:31:05 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, "David S. Miller" <davem@...emloft.net>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Chris Brandt <chris.brandt@...esas.com>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: sh_eth: fix a missing check of of_get_phy_mode

Hello!

On 12.03.2019 9:30, Kangjie Lu wrote:

> of_get_phy_mode may fail and return a negative error code;
> the fix checks the return value of of_get_phy_mode and
> returns NULL of it fails.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
>   drivers/net/ethernet/renesas/sh_eth.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 239eeafe1b2d..e33af371b169 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -3181,14 +3181,16 @@ static struct sh_eth_plat_data *sh_eth_parse_dt(struct device *dev)
>   	struct device_node *np = dev->of_node;
>   	struct sh_eth_plat_data *pdata;
>   	const char *mac_addr;
> +	int ret;
>   
>   	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
>   	if (!pdata)
>   		return NULL;
>   
> -	pdata->phy_interface = of_get_phy_mode(np);
> -	if (pdata->phy_interface < 0)

    Please generate your patch against the pristine net.git, not atop
of your previous version.

> +	ret = of_get_phy_mode(np);
> +	if (ret < 0)
>   		return NULL;
> +	pdata->phy_interface = ret;
>   
>   	mac_addr = of_get_mac_address(np);
>   	if (mac_addr)
> 

MBR, Sergei