netdev - Re: BUG: "13d0ab6750b2 net: phy: check return code when requesting PHY driver module" breaks NFS-Root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3551d4a0-8b5a-525e-49ff-8a0d00dcc840@pengutronix.de>
Date:   Tue, 12 Mar 2019 09:02:40 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        ptx kernel <kernel@...gutronix.de>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: BUG: "13d0ab6750b2 net: phy: check return code when requesting
 PHY driver module" breaks NFS-Root

On 3/11/19 7:11 PM, Florian Fainelli wrote:
>> I continued bisecting and found a bad commit in the riotboard's phy
>> driver. I'll send a separate mail for this.
>>
>> | cd28d1d6e52e net: phy: at803x: Disable phy delay for RGMII mode
> 
> If your problem is with this driver, keep in mind that the at803x PHY
> driver incorrectly acted on the 'phy-mode'/phy_interface_t type and you
> may need DTS changes to be conforming. Of course, there is no way to
> programmatically detect any of that, which adds to the fun.

Thanks for the tip, that was the problem. Changing the phy-mode to
rgmii-id restores the old behaviour in the driver and the board boots again.

I'll send a patch.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)