netdev - Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Mar 2019 07:21:02 -0400
From:   Neil Horman <nhorman@...driver.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, marcelo.leitner@...il.com,
        lucien.xin@...il.com
Subject: Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul.

On Mon, Mar 11, 2019 at 08:09:19PM -0700, David Miller wrote:
> 
> This patch series eliminates the explicit reference to the skb list
> implementation via skb->prev dereferences.
> 
> The approach used is to pass a non-empty skb list around instead of an
> event skb object which may or may not be on a list.
> 
> I'd like to thank Marcelo Leitner, Xin Long, and Neil Horman for
> reviewing previous versions of this series.
> 
> Testing would be very much appreciated, in addition to the review of
> course.
> 
> v3 --> v4: Fix the logic in patch #4 so that we don't miss cases
>        	   where we should add event to the on-stack temp list.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> 

I think this looks good now, thanks for taking the time on it Dave

Acked-by: Neil Horman <nhorman@...driver.com>