lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Mar 2019 19:37:15 +0100 From: Florian Weimer <fw@...eb.enyo.de> To: Arnd Bergmann <arnd@...db.de> Cc: "David S . Miller" <davem@...emloft.net>, Deepa Dinamani <deepa.kernel@...il.com>, Willem de Bruijn <willemb@...gle.com>, linux-alpha@...r.kernel.org, linux-arch@...r.kernel.org, linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org, sparclinux@...r.kernel.org, Laura Abbott <labbott@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-api@...r.kernel.org Subject: Re: [PATCH] y2038: fix socket.h header inclusion * Arnd Bergmann: > diff --git a/arch/alpha/include/uapi/asm/socket.h b/arch/alpha/include/uapi/asm/socket.h > index 0d0fddb7e738..976e89b116e5 100644 > --- a/arch/alpha/include/uapi/asm/socket.h > +++ b/arch/alpha/include/uapi/asm/socket.h > @@ -2,8 +2,8 @@ > #ifndef _UAPI_ASM_SOCKET_H > #define _UAPI_ASM_SOCKET_H > > +#include <linux/posix_types.h> > #include <asm/sockios.h> > -#include <asm/bitsperlong.h> This breaks POSIX conformance in glibc because the <linux/posix_types.h> header is not namespace clean. It contains the identifiers fds_bits and val: unsigned long fds_bits[__FD_SETSIZE / (8 * sizeof(long))]; int val[2]; We could duplicate some of the SO_* constants for POSIX mode in glibc, but it would be nice to avoid that. Is there a different way of fixing this on the kernel side that avoids including <linux/posix_types.h>?
Powered by blists - more mailing lists