lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Mar 2019 12:40:20 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Daniel Borkmann <daniel@...earbox.net> Cc: Alexei Starovoitov <ast@...nel.org>, bpf@...r.kernel.org, Networking <netdev@...r.kernel.org>, Joe Stringer <joe@...d.net.nz>, john fastabend <john.fastabend@...il.com>, Yonghong Song <yhs@...com>, Jakub Kicinski <jakub.kicinski@...ronome.com>, tgraf@...g.ch, lmb@...udflare.com Subject: Re: [PATCH rfc v3 bpf-next 4/9] bpf, obj: allow . char as part of the name On Mon, Mar 11, 2019 at 2:51 PM Daniel Borkmann <daniel@...earbox.net> wrote: > > Trivial addition to allow '.' aside from '_' as "special" characters > in the object name. Used to allow for substrings in maps from loader > side such as ".bss", ".data", ".rodata", but could also be useful for > other purposes. > > Signed-off-by: Daniel Borkmann <daniel@...earbox.net> Acked-by: Andrii Nakryiko <andriin@...com> > --- > kernel/bpf/syscall.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c > index b5ba138351e1..04279747c092 100644 > --- a/kernel/bpf/syscall.c > +++ b/kernel/bpf/syscall.c > @@ -456,10 +456,10 @@ static int bpf_obj_name_cpy(char *dst, const char *src) > const char *end = src + BPF_OBJ_NAME_LEN; > > memset(dst, 0, BPF_OBJ_NAME_LEN); > - > - /* Copy all isalnum() and '_' char */ > + /* Copy all isalnum(), '_' and '.' chars. */ > while (src < end && *src) { > - if (!isalnum(*src) && *src != '_') > + if (!isalnum(*src) && > + *src != '_' && *src != '.') > return -EINVAL; > *dst++ = *src++; > } > -- > 2.17.1 >
Powered by blists - more mailing lists