lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Mar 2019 16:17:24 -0500 From: Aditya Pakki <pakki001@....edu> To: pakki001@....edu Cc: kjlu@....edu, Ilya Dryomov <idryomov@...il.com>, "Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>, "David S. Miller" <davem@...emloft.net>, ceph-devel@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] libceph: Avoid a NULL pointer dereference kmalloc allocates memory for dest->name and attempts to call memcpy without a check for failure. This patch avoids such a scenario. Signed-off-by: Aditya Pakki <pakki001@....edu> --- net/ceph/osdmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c index 48a31dc9161c..c76a7c7e6a77 100644 --- a/net/ceph/osdmap.c +++ b/net/ceph/osdmap.c @@ -1901,6 +1901,8 @@ void ceph_oid_copy(struct ceph_object_id *dest, } else { dest->name = dest->inline_name; } + if (!dest->name) + return; memcpy(dest->name, src->name, src->name_len + 1); dest->name_len = src->name_len; } -- 2.17.1
Powered by blists - more mailing lists