lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Mar 2019 14:19:42 +0100 From: Rasmus Villemoes <linux@...musvillemoes.dk> To: Pavel Machek <pavel@....cz> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Jacek Anaszewski <jacek.anaszewski@...il.com>, LKML <linux-kernel@...r.kernel.org>, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, linux-can@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 4/4] leds: netdev trigger: allow setting initial values in device tree On 14/03/2019 13.00, Pavel Machek wrote: linux,default-trigger from > > Yeah and now insert the modules for the can devices in different > order... May not happen in your case but will be fairly common for > ethernets. Unpredictable device names is not a problem I'm trying to solve, nor one that actually occurs on embedded systems. And even if one has such a system, one is likely running udev or similar to rename devices to something sane and predictable, in which case a fixed string _still_ works fine. Or one uses udev rules to munge the netdev trigger sysfs files, and has applications dealing with devices appearing as banana457. OK, so there's of_find_net_device_by_node, so a phandle solution might also be possible, and might work just as well for my case. But I still think initializing with a fixed string is the simplest and sanest thing to do. Rasmus
Powered by blists - more mailing lists