netdev - Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0881e08-95d7-8f8e-125f-9aa37ed9ff2f@gmail.com>
Date:   Fri, 15 Mar 2019 14:58:32 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Phil Reid <preid@...ctromag.com.au>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        dongsheng.wang@...-semitech.com, cphealy@...il.com,
        clemens.gruber@...ruber.com, hkallweit1@...il.com, nbd@....name,
        harini.katakam@...inx.com
Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

On 3/15/19 1:52 AM, Phil Reid wrote:
> G'day All,
> 
> I've just update from kernel 4.19 to 5.0 on a custom board that has a
> marvell
> dsa mv88e6085 and the phy on the mv88e6085 will only connect at 10Mb/s with
> the above mentioned patch applied.
> 
> Bisecting the issue lead me to the following patch.
> 
> d6ab93364734bd (net: phy: marvell: Avoid unnecessary soft reset)
> 
> Revert the patch, and the associated build fix
> 4b1bd6976945417 (net: phy: marvell: Fix build.)
> restores connections to 1Gb/s.
> 
> Anyone have any thoughts as to the correct fix?

What is the PHY OUI (MII_PHYSID1/ID2) for that PHY? We may need to add a
specific entry in drivers/net/phy/marvell.c to restore the software
reset to commit changes to the register.
-- 
Florian