netdev - Re: [PATCH 2/2] net: stmmac: fix jumbo frame sending with non-linear skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Mar 2019 09:50:15 +0000
From:   Jose Abreu <jose.abreu@...opsys.com>
To:     Aaro Koskinen <aaro.koskinen@....fi>,
        "David S. Miller" <davem@...emloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <jose.abreu@...opsys.com>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Aaro Koskinen <aaro.koskinen@...ia.com>
Subject: Re: [PATCH 2/2] net: stmmac: fix jumbo frame sending with non-linear
 skbs

On 3/14/2019 7:43 PM, Aaro Koskinen wrote:
> From: Aaro Koskinen <aaro.koskinen@...ia.com>
> 
> When sending non-linear skbs with jumbo frames, we set up the non-paged
> data and mark that as a last segment, although the paged fragments are
> also prepared. This will stall the TX queue and trigger a watchdog warning
> (a simple reproducer is to run an iperf client mode TCP test with a large
> MTU - networking fails instantly).
> 
> Fix by checking if the skb is non-linear.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>

Acked-by: Jose Abreu <joabreu@...opsys.com>

Thanks,
Jose Miguel Abreu