netdev - Re: [PATCH] vxlan: remove the redundant gro_cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315125434.093afbd1@elisabeth>
Date:   Fri, 15 Mar 2019 12:54:34 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Zhiqiang Liu <liuzhiqiang26@...wei.com>
Cc:     <davem@...emloft.net>, <petrm@...lanox.com>, <idosch@...lanox.com>,
        <sd@...asysnail.net>, <mousuanming@...wei.com>,
        <netdev@...r.kernel.org>, Mingfangsen <mingfangsen@...wei.com>,
        "Zhoukang (A)" <zhoukang7@...wei.com>,
        "wangxiaogang (F)" <wangxiaogang3@...wei.com>
Subject: Re: [PATCH] vxlan: remove the redundant gro_cells_destroy()
 calling.

On Fri, 15 Mar 2019 18:06:45 +0800
Zhiqiang Liu <liuzhiqiang26@...wei.com> wrote:

> From: "Suanming.Mou" <mousuanming@...wei.com>
> 
> With ad6c9986bcb6, GRO cells will be destroyed in vxlan_uninit.

Thanks for cleaning this up.

I think it would be nice if you could actually explain in the commit
message why this makes the call in vxlan_destroy_tunnels() redundant.

> Fixes: ad6c9986bcb6 ("vxlan: Fix GRO cells race condition between receive and link delete")

I'm not sure a Fixes: tag is appropriate here (and also if this
shouldn't be targeted for net-next) -- in the end, gro_cells_destroy()
there would just return:

        if (!gcells->cells)
                return;

> Signed-off-by: Suanming.Mou <mousuanming@...wei.com>

Either way,

Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano