netdev - Re: [PATCH net-next] net: phy: improve handling link_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <552608df-fbf8-0937-ef64-4ee4d4ccb3d7@rock-chips.com>
Date:   Fri, 15 Mar 2019 21:29:39 +0800
From:   David Wu <david.wu@...k-chips.com>
To:     Daniel Mack <daniel@...que.org>, Heiko Stuebner <heiko@...ech.de>,
        Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>, hkallweit1@...il.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify
 callback



在 2019/3/13 上午1:50, Daniel Mack 写道:
> On 12/3/2019 1:27 PM, Heiko Stuebner wrote:
>> Hi Andrew, Heiner,
>>
>> Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn:
>>> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote:
>>>> From: Heiner Kallweit <hkallweit1@...il.com>
>>>> Date: Sun, 3 Mar 2019 19:58:57 +0100
>>>>
>>>>> Currently the Phy driver's link_change_notify callback is called
>>>>> whenever the state machine is run (every second if polling), no matter
>>>>> whether the state changed or not. This isn't needed and may confuse
>>>>> users considering the name of the callback. Therefore let's change
>>>>> the behavior and call this callback only in case of an actual
>>>>> state change.
>>>>>
>>>>> This requires changes to the at803x and rockchip drivers.
>>>>> at803x can be simplified so that it reacts on a state change to
>>>>> PHY_NOLINK only.
>>>>> The rockchip driver can also be much simplified. We simply re-init
>>>>> the AFE/DSP registers whenever we change to PHY_RUNNING and speed
>>>>> is 100Mbps. This causes very small overhead because we do this even
>>>>> if the speed was 100Mbps already. But this is neglectable and
>>>>> I think justified by the much simpler code.
>>>>>
>>>>> Changes are compile-tested only.
>>>>>
>>>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>>>>
>>>> Someone please review this.
>>>
>>> Hi David
>>>
>>> We should probably wait for a Tested-by: from Daniel Mack
>>> <zonque@...il.com> and David Wu <david.wu@...k-chips.com>, or
>>> equivalent.
>>
>> We should probably add them to the list of recipients if we want
>> tests from them, which I've done now.
>>
>> @David: patch in question that changes the Rockchip eth-phy is
>> https://patchwork.kernel.org/patch/10837217/

I think i can find a hardware to test this.

>>
>> Sadly I don't have matching hardware to test this myself.
> 
> Thanks for considering me, but I don't have access to that hardware
> either right now.
> 
> The changes look straight forward to me however, so just go ahead an
> apply this. Once I get back to that setup, I'll report in case of a
> regression.
> 
> 
> Thanks,
> Dainel
> 
> 
>