netdev - Re: [PATCH v2] appletalk: Fix potential NULL pointer dereference in unregister_snap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190315.112613.282237147383602540.davem@davemloft.net>
Date:   Fri, 15 Mar 2019 11:26:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     joe@...ches.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] appletalk: Fix potential NULL pointer dereference
 in unregister_snap_client

From: Yue Haibing <yuehaibing@...wei.com>
Date: Thu, 14 Mar 2019 13:47:59 +0800

> From: YueHaibing <yuehaibing@...wei.com>
> 
> register_snap_client may return NULL, all the callers
> check it, but only print a warning. This will result in
> NULL pointer dereference in unregister_snap_client and other
> places.
> 
> It has always been used like this since v2.6
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: del timer in aarp_proto_init error patch

Applied, thanks for following up.