netdev - Re: [PATCH 2/2] net: stmmac: fix jumbo frame sending with non-linear skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190315.113923.1281526892950673180.davem@davemloft.net>
Date:   Fri, 15 Mar 2019 11:39:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     aaro.koskinen@....fi
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, thor.thayer@...ux.intel.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        aaro.koskinen@...ia.com
Subject: Re: [PATCH 2/2] net: stmmac: fix jumbo frame sending with
 non-linear skbs

From: Aaro Koskinen <aaro.koskinen@....fi>
Date: Thu, 14 Mar 2019 21:43:20 +0200

> From: Aaro Koskinen <aaro.koskinen@...ia.com>
> 
> When sending non-linear skbs with jumbo frames, we set up the non-paged
> data and mark that as a last segment, although the paged fragments are
> also prepared. This will stall the TX queue and trigger a watchdog warning
> (a simple reproducer is to run an iperf client mode TCP test with a large
> MTU - networking fails instantly).
> 
> Fix by checking if the skb is non-linear.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>

Applied.