netdev - Re: [PATCH bpf] xsk: fix umem memory leak on cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a49783b-9ddb-af6f-494b-2aa28bffe513@iogearbox.net>
Date:   Sat, 16 Mar 2019 01:31:25 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, netdev@...r.kernel.org, jslaby@...e.cz
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com, magnus.karlsson@...il.com,
        bpf@...r.kernel.org
Subject: Re: [PATCH bpf] xsk: fix umem memory leak on cleanup

On 03/13/2019 03:15 PM, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> When the umem is cleaned up, the task that created it might already be
> gone. If the task was gone, the xdp_umem_release function did not free
> the pages member of struct xdp_umem.
> 
> It turned out that the task lookup was not needed at all; The code was
> a left-over when we moved from task accounting to user accounting [1].
> 
> This patch fixes the memory leak by removing the task lookup logic
> completely.
> 
> [1] https://lore.kernel.org/netdev/20180131135356.19134-3-bjorn.topel@gmail.com/
> 
> Link: https://lore.kernel.org/netdev/c1cb2ca8-6a14-3980-8672-f3de0bb38dfd@suse.cz/
> Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt")
> Reported-by: Jiri Slaby <jslaby@...e.cz>
> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>

Applied, thanks!