netdev - Re: r8169 driver from kernel 5.0 crashing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df7a7e3a-143e-f1ee-cbea-2612d953b122@gmail.com>
Date:   Sun, 17 Mar 2019 16:49:54 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     VDR User <user.vdr@...il.com>
Cc:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        netdev@...r.kernel.org
Subject: Re: r8169 driver from kernel 5.0 crashing - napi_consume_skb

On 17.03.2019 16:41, VDR User wrote:
> A quick comment on patch 1:
> 
>> @@ -1294,6 +1295,7 @@ static void rtl_ack_events(struct rtl8169_private *tp, u16 bits)
>>  static void rtl_irq_disable(struct rtl8169_private *tp)
>>  {
>>         RTL_W16(tp, IntrMask, 0);
>> +       tp->irq_enabled = 0;
>>  }
> 
> This function is slightly different in the vanilla 5.0 driver:
> 
Right, the patch is based on latest linux-next.

> static void rtl_irq_disable(struct rtl8169_private *tp)
> {
>         RTL_W16(tp, IntrMask, 0);
>         mmiowb();
> }
> 
> Unless that mmiowb() matters, I'll continue.
> 
No, it doesn't matter.

> Derek
> 
Heiner