[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190318.165359.1331225821043608638.davem@davemloft.net>
Date: Mon, 18 Mar 2019 16:53:59 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: edumazet@...gle.com
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: rose: fix a possible stack overflow
From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 15 Mar 2019 10:41:14 -0700
> rose_write_internal() uses a temp buffer of 100 bytes, but a manual
> inspection showed that given arbitrary input, rose_create_facilities()
> can fill up to 110 bytes.
>
> Lets use a tailroom of 256 bytes for peace of mind, and remove
> the bounce buffer : we can simply allocate a big enough skb
> and adjust its length as needed.
>
> syzbot report :
...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
Applied, thanks Eric.
Powered by blists - more mailing lists