netdev - Re: [PATCH v4] ipvs: allow tunneling with gue encapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Mar 2019 10:10:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jacky Hu <hengqing.hu@...il.com>
Cc:     kbuild-all@...org, hengqing.hu@...il.com, jacky.hu@...mart.com,
        jason.niesz@...mart.com, Wensong Zhang <wensong@...ux-vs.org>,
        Simon Horman <horms@...ge.net.au>,
        Julian Anastasov <ja@....bg>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        lvs-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org
Subject: Re: [PATCH v4] ipvs: allow tunneling with gue encapsulation

Hi Jacky,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ipvs-next/master]
[also build test WARNING on v5.1-rc1 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jacky-Hu/ipvs-allow-tunneling-with-gue-encapsulation/20190318-070156
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

   net/netfilter/ipvs/ip_vs_ctl.c:835:42: sparse: incorrect type in argument 2 (different base types) @@    expected int [signed] i @@    got restricted __be1int [signed] i @@
   net/netfilter/ipvs/ip_vs_ctl.c:835:42:    expected int [signed] i
   net/netfilter/ipvs/ip_vs_ctl.c:835:42:    got restricted __be16 [usertype] tun_port
   net/netfilter/ipvs/ip_vs_ctl.c:1197:44: sparse: expression using sizeof(void)
>> net/netfilter/ipvs/ip_vs_ctl.c:3207:37: sparse: incorrect type in argument 3 (different base types) @@    expected restricted __be16 [usertype] value @@    got e] value @@
   net/netfilter/ipvs/ip_vs_ctl.c:3207:37:    expected restricted __be16 [usertype] value
   net/netfilter/ipvs/ip_vs_ctl.c:3207:37:    got int
   net/netfilter/ipvs/ip_vs_ctl.c:1313:27: sparse: dereference of noderef expression

vim +3207 net/netfilter/ipvs/ip_vs_ctl.c

  3187	
  3188	static int ip_vs_genl_fill_dest(struct sk_buff *skb, struct ip_vs_dest *dest)
  3189	{
  3190		struct nlattr *nl_dest;
  3191		struct ip_vs_kstats kstats;
  3192	
  3193		nl_dest = nla_nest_start(skb, IPVS_CMD_ATTR_DEST);
  3194		if (!nl_dest)
  3195			return -EMSGSIZE;
  3196	
  3197		if (nla_put(skb, IPVS_DEST_ATTR_ADDR, sizeof(dest->addr), &dest->addr) ||
  3198		    nla_put_be16(skb, IPVS_DEST_ATTR_PORT, dest->port) ||
  3199		    nla_put_u32(skb, IPVS_DEST_ATTR_FWD_METHOD,
  3200				(atomic_read(&dest->conn_flags) &
  3201				 IP_VS_CONN_F_FWD_MASK)) ||
  3202		    nla_put_u32(skb, IPVS_DEST_ATTR_WEIGHT,
  3203				atomic_read(&dest->weight)) ||
  3204		    nla_put_u8(skb, IPVS_DEST_ATTR_TUN_TYPE,
  3205			       atomic_read(&dest->tun_type)) ||
  3206		    nla_put_be16(skb, IPVS_DEST_ATTR_TUN_PORT,
> 3207				 atomic_read(&dest->tun_port)) ||
  3208		    nla_put_u32(skb, IPVS_DEST_ATTR_U_THRESH, dest->u_threshold) ||
  3209		    nla_put_u32(skb, IPVS_DEST_ATTR_L_THRESH, dest->l_threshold) ||
  3210		    nla_put_u32(skb, IPVS_DEST_ATTR_ACTIVE_CONNS,
  3211				atomic_read(&dest->activeconns)) ||
  3212		    nla_put_u32(skb, IPVS_DEST_ATTR_INACT_CONNS,
  3213				atomic_read(&dest->inactconns)) ||
  3214		    nla_put_u32(skb, IPVS_DEST_ATTR_PERSIST_CONNS,
  3215				atomic_read(&dest->persistconns)) ||
  3216		    nla_put_u16(skb, IPVS_DEST_ATTR_ADDR_FAMILY, dest->af))
  3217			goto nla_put_failure;
  3218		ip_vs_copy_stats(&kstats, &dest->stats);
  3219		if (ip_vs_genl_fill_stats(skb, IPVS_DEST_ATTR_STATS, &kstats))
  3220			goto nla_put_failure;
  3221		if (ip_vs_genl_fill_stats64(skb, IPVS_DEST_ATTR_STATS64, &kstats))
  3222			goto nla_put_failure;
  3223	
  3224		nla_nest_end(skb, nl_dest);
  3225	
  3226		return 0;
  3227	
  3228	nla_put_failure:
  3229		nla_nest_cancel(skb, nl_dest);
  3230		return -EMSGSIZE;
  3231	}
  3232	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation