netdev - Re: [PATCH net V3 0/2] net/sched: taprio: cbs: Fix using invalid link speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2E21E7FA-35CF-4363-91A6-4C4EE5B6ED93@intel.com>
Date:   Tue, 19 Mar 2019 00:07:15 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     "Dorileo, Leandro" <leandro.maciel.dorileo@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S . Miller" <davem@...emloft.net>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>
Subject: Re: [PATCH net V3 0/2] net/sched: taprio: cbs: Fix using invalid
 link speed

I agree with Florian's minor comment regarding pr_info->netdev_dgb change. 

But, apart from that, I reviewed both the patches look good to me:

Reviewed-By: Vedang Patel <vedang.patel@...el.com>

On 3/15/19, 2:17 PM, "netdev-owner@...r.kernel.org on behalf of Leandro Dorileo" <netdev-owner@...r.kernel.org on behalf of leandro.maciel.dorileo@...el.com> wrote:

    This set fixes miscalculations based on invalid link speed values.
    
    Changes in v3:
     + yep pr_info() format warnings;
    
    Changes in v2:
     + fixed pr_info() format both on cbs and taprio patches;
    
    Leandro Dorileo (2):
      net/sched: taprio: fix picos_per_byte miscalculation
      net/sched: cbs: fix port_rate miscalculation
    
     net/sched/sch_cbs.c    | 91 +++++++++++++++++++++++++++++++++++-------
     net/sched/sch_taprio.c | 90 +++++++++++++++++++++++++++++++++--------
     2 files changed, 151 insertions(+), 30 deletions(-)
    
    -- 
    2.21.0