netdev - Re: [PATCH] net: stmmac: fix memory corruption with large MTUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190319.133344.1485034729701481720.davem@davemloft.net>
Date:   Tue, 19 Mar 2019 13:33:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     aaro.koskinen@....fi
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, aaro.koskinen@...ia.com
Subject: Re: [PATCH] net: stmmac: fix memory corruption with large MTUs

From: Aaro Koskinen <aaro.koskinen@....fi>
Date: Mon, 18 Mar 2019 23:36:08 +0200

> From: Aaro Koskinen <aaro.koskinen@...ia.com>
> 
> When using 16K DMA buffers and ring mode, the DES3 refill is not working
> correctly as the function is using a bogus pointer for checking the
> private data. As a result stale pointers will remain in the RX descriptor
> ring, so DMA will now likely overwrite/corrupt some already freed memory.
> 
> As simple reproducer, just receive some UDP traffic:
 ...
> Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>

Applied and queued up for -stable, thank you.