netdev - Re: [PATCH] net: mvneta: Switch to using devm_alloc_etherdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190319.150504.2058739004594107706.davem@davemloft.net>
Date:   Tue, 19 Mar 2019 15:05:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rosenp@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: mvneta: Switch to using devm_alloc_etherdev_mqs

From: Rosen Penev <rosenp@...il.com>
Date: Tue, 19 Mar 2019 13:53:40 -0700

> It allows some of the code to be simplified.
 ...
> @@ -4641,9 +4640,6 @@ static int mvneta_probe(struct platform_device *pdev)
>  		phylink_destroy(pp->phylink);
>  err_free_irq:
>  	irq_dispose_mapping(dev->irq);
> -err_free_netdev:
> -	free_netdev(dev);
> -	return err;

It would be great if the code was compile tested too.

You're removing the error return the err_free_irq: path needs.