netdev - Re: [PATCH] 3c515: fix integer overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Mar 2019 15:08:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 3c515: fix integer overflow warning

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 19 Mar 2019 22:15:58 +0100

> clang points out a harmless signed integer overflow:
> 
> drivers/net/ethernet/3com/3c515.c:1530:66: error: implicit conversion from 'int' to 'short' changes value from 32783 to -32753 [-Werror,-Wconstant-conversion]
>                 new_mode = SetRxFilter | RxStation | RxMulticast | RxBroadcast | RxProm;
>                          ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
> drivers/net/ethernet/3com/3c515.c:1532:52: error: implicit conversion from 'int' to 'short' changes value from 32775 to -32761 [-Werror,-Wconstant-conversion]
>                 new_mode = SetRxFilter | RxStation | RxMulticast | RxBroadcast;
>                          ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
> drivers/net/ethernet/3com/3c515.c:1534:38: error: implicit conversion from 'int' to 'short' changes value from 32773 to -32763 [-Werror,-Wconstant-conversion]
>                 new_mode = SetRxFilter | RxStation | RxBroadcast;
>                          ~ ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
> 
> Make the variable unsigned to avoid the overflow.
> 
> Fixes: Linux-2.1.128pre1
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.