netdev - Re: [PATCH iproute2-next] tc: m_connmark: fix action error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190319152317.61f647de@shemminger-XPS-13-9360>
Date:   Tue, 19 Mar 2019 15:23:17 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2-next] tc: m_connmark: fix action error messages

On Fri, 15 Mar 2019 10:50:45 +0000
Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk> wrote:

> action m_connmark returns error messages identifying itself as the
> 'simple' action instead of 'connmark' action. e.g.
> 
> tc filter add dev eth0 protocol all u32 match u32 0 0 flowid 1:1 \
> 	action connmark index wrong
> simple: Illegal "index"
> bad action parsing
> parse_action: bad value (3:connmark)!
> Illegal "action"
> 
> In what is most likely a copy/paste error from the simple action example
> code, fix connmark error messages to identify themselves as coming from
> connmark.
> 
> tc filter add dev eth0 protocol all u32 match u32 0 0 flowid 1:1 \
> 	action connmark index wrong
> connmark: Illegal "index"
> bad action parsing
> parse_action: bad value (3:connmark)!
> Illegal "action"
> 
> While we're here also fixup the 'Illegal "Zone"' error code to say
> 'Illegal "zone"' instead of 'Illegal "index"'
> 
> Signed-off-by: Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>

Applied (just before tagging 5.0).