netdev - Re: [PATCH net] packets: Always register packet sk in the same order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190318.175948.1678106009838663617.davem@davemloft.net>
Date:   Mon, 18 Mar 2019 17:59:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     maxime.chevallier@...tlin.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, willemb@...gle.com, edumazet@...gle.com,
        antoine.tenart@...tlin.com, thomas.petazzoni@...tlin.com
Subject: Re: [PATCH net] packets: Always register packet sk in the same
 order

From: David Miller <davem@...emloft.net>
Date: Sat, 16 Mar 2019 18:21:19 -0700 (PDT)

> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Date: Sat, 16 Mar 2019 14:09:33 -0400
> 
>> Note that another consequence of this patch is that insertion on
>> packet create is now O(N) with the number of active packet sockets,
>> due to sklist being an hlist.
> 
> Exploitable...

After reading Willem's explanation of how the scope of such a problem
is constrained, I am going to apply this and queue it up for -stable.

Maybe in the long term we can do the hlist reverse RCU thing.