netdev - Re: [PATCH] net-sysfs: Fix memory leak in netdev_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190319102244.GC9224@smile.fi.intel.com>
Date:   Tue, 19 Mar 2019 12:22:44 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "wanghai (M)" <wanghai26@...wei.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        davem@...emloft.net, idosch@...lanox.com,
        alexander.h.duyck@...el.com, tyhicks@...onical.com,
        f.fainelli@...il.com, amritha.nambiar@...el.com, joe@...ches.com,
        dmitry.torokhov@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net-sysfs: Fix memory leak in netdev_register_kobject

On Tue, Mar 19, 2019 at 11:39:54AM +0800, wanghai (M) wrote:
> 在 2019/3/19 11:15, Stephen Hemminger 写道:

> Device_del just delete device from system, but do not clean up
> dev->kobj.name.

May I ask how you get this conclusion?

>	In normal case,     the name is freed  in free_netdev(dev)->put_device(&dev->dev)->kobject_put(&dev->kobj)->kobject_cleanup()
> ,not in device_del()

-- 
With Best Regards,
Andy Shevchenko