netdev - Re: [PATCHv2 net] sctp: get sctphdr by offset in sctp_compute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190318.182415.2239605199956582343.davem@davemloft.net>
Date:   Mon, 18 Mar 2019 18:24:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org, fw@...len.de,
        marcelo.leitner@...il.com, nhorman@...driver.com
Subject: Re: [PATCHv2 net] sctp: get sctphdr by offset in sctp_compute_cksum

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 18 Mar 2019 19:47:00 +0800

> sctp_hdr(skb) only works when skb->transport_header is set properly.
> 
> But in Netfilter, skb->transport_header for ipv6 is not guaranteed
> to be right value for sctphdr. It would cause to fail to check the
> checksum for sctp packets.
> 
> So fix it by using offset, which is always right in all places.
> 
> v1->v2:
>   - Fix the changelog.
> 
> Fixes: e6d8b64b34aa ("net: sctp: fix and consolidate SCTP checksumming code")
> Reported-by: Li Shuang <shuali@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable.