netdev - Re: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32 architecture.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98323a41-2851-d000-c928-242d055a5bc1@iogearbox.net>
Date:   Wed, 20 Mar 2019 15:07:20 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Hassan Naveed <hnaveed@...ecomp.com>,
        Paul Burton <pburton@...ecomp.com>
Cc:     "kafai@...com" <kafai@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "yhs@...com" <yhs@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        "open list:MIPS" <linux-mips@...ux-mips.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32
 architecture.

On 03/12/2019 11:48 PM, Hassan Naveed wrote:
> Currently MIPS32 supports a JIT for classic BPF only, not extended BPF.
> This patch adds JIT support for extended BPF on MIPS32, so code is
> actually JIT'ed instead of being only interpreted. Instructions with
> 64-bit operands are not supported at this point.
> We can delete classic BPF because the kernel will translate classic BPF
> programs into extended BPF and JIT them, eliminating the need for
> classic BPF.
> 
> Signed-off-by: Hassan Naveed <hnaveed@...ecomp.com>

Nice! Did you check BPF test suite (lib/test_bpf.ko) that both before/after
the same number of cBPF programs could be JITed?

Please also follow-up to update Documentation/sysctl/net.txt, bpf_jit_enable
section, and adding yourself as co-maintainer for 'BPF JIT for MIPS' wouldn't
hurt either if Paul would be good with that, too.

Any plans on completing eBPF support for mips32?

Thanks,
Daniel