netdev - Re: [PATCH] bpf, tests: tweak endianness selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 10:51:24 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Stanislav Fomichev <sdf@...ichev.me>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH] bpf, tests: tweak endianness selection

On (03/19/19 09:01), Stanislav Fomichev wrote:
> > diff --git a/tools/testing/selftests/bpf/bpf_endian.h b/tools/testing/selftests/bpf/bpf_endian.h
> > index b25595ea4a78..ba06222963d5 100644
> > --- a/tools/testing/selftests/bpf/bpf_endian.h
> > +++ b/tools/testing/selftests/bpf/bpf_endian.h
> > @@ -20,38 +20,17 @@
> >   * use different targets.
> >   */
> >  #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> > -# define __bpf_ntohs(x)			__builtin_bswap16(x)
> > -# define __bpf_htons(x)			__builtin_bswap16(x)
> > -# define __bpf_constant_ntohs(x)	___constant_swab16(x)
> > -# define __bpf_constant_htons(x)	___constant_swab16(x)
> This breaks the build until your next patch is applied (in other
> words, breaks bisection). Can we do it in three steps?

Bummer!
I thought about applying the second patch (flow_dissector.c) first
and then the first one (bpf/bpf_endian.h).

> Convert to swab (without breaking existing tests), convert the tests,
> remove unused __bpf_xyz defines?

OK.

> Could you also send it as a series (git format-patch --thread)? Those
> patches depend on each other. And pls use [PATCH bpf-next] ... subj.

Right. I figured out that I also need to patch flow_dissector.c after
I sent out bpf/bpf_endian.h patch.

Sorry about that, will fix.

	-ss