netdev - Re: [PATCH net-next] net: phy: improve handling link_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190320.105010.192905616973367477.davem@davemloft.net>
Date:   Wed, 20 Mar 2019 10:50:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, heiko@...ech.de,
        david.wu@...k-chips.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify
 callback

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 19 Mar 2019 19:56:51 +0100

> Currently the Phy driver's link_change_notify callback is called
> whenever the state machine is run (every second if polling), no matter
> whether the state changed or not. This isn't needed and may confuse
> users considering the name of the callback. Actually it contradicts
> its kernel-doc description. Therefore let's change the behavior and
> call this callback only in case of an actual state change.
> 
> This requires changes to the at803x and rockchip drivers.
> at803x can be simplified so that it reacts on a state change to
> PHY_NOLINK only.
> The rockchip driver can also be much simplified. We simply re-init
> the AFE/DSP registers whenever we change to PHY_RUNNING and speed
> is 100Mbps. This causes very small overhead because we do this even
> if the speed was 100Mbps already. But this is negligible and
> I think justified by the much simpler code.
> 
> Changes are compile-tested only.
> 
> A little bit problematic seems to be to find somebody with the
> hardware to test the changes to the two PHY drivers. See also [0].
> David may be able to test the Rockchip driver.
> 
> [0] https://marc.info/?t=153782508800006&r=1&w=2
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

I'm just going to apply this, let's see what happens as I don't really see
any value after all of this time of waiting for testing that may or may not
happen.

We can always revert.

Thanks.