netdev - Re: [PATCH net-next v2] net/tls: Add support of AES128-CCM based ciphers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190320.110220.1289822453962808039.davem@davemloft.net>
Date:   Wed, 20 Mar 2019 11:02:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com, doronrk@...com
Subject: Re: [PATCH net-next v2] net/tls: Add support of AES128-CCM based
 ciphers

From: Vakul Garg <vakul.garg@....com>
Date: Wed, 20 Mar 2019 02:03:36 +0000

> Added support for AES128-CCM based record encryption. AES128-CCM is
> similar to AES128-GCM. Both of them have same salt/iv/mac size. The
> notable difference between the two is that while invoking AES128-CCM
> operation, the salt||nonce (which is passed as IV) has to be prefixed
> with a hardcoded value '2'. Further, CCM implementation in kernel
> requires IV passed in crypto_aead_request() to be full '16' bytes.
> Therefore, the record structure 'struct tls_rec' has been modified to
> reserve '16' bytes for IV. This works for both GCM and CCM based cipher.
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>
> ---
> Changes in v2:
> 	- Defined a CPP macro to replace hardcoded constant '2' used in
> 	  first byte of CCM IV.

Applied, thanks for following up.