netdev - Re: [RFC PATCH net-next] selftests: tc-testing: Add pedit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMDBHY+SsR=js7tySt5_bPB-BGFqU83OGvPrXa0ugTNj6_X6cw@mail.gmail.com>
Date:   Wed, 20 Mar 2019 15:41:13 -0400
From:   Lucas Bates <lucasb@...atatu.com>
To:     Dmytro Linkin <dmitrolin@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, shuah@...nel.org,
        Davide Caratti <dcaratti@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Buslov <vladbu@...lanox.com>
Subject: Re: [RFC PATCH net-next] selftests: tc-testing: Add pedit tests

On Fri, Mar 1, 2019 at 7:33 AM Dmytro Linkin <dmitrolin@...lanox.com> wrote:
>
> Add 36 pedit action tests to check pedit options described in tc-pedit(8)
> man page. Test cases can be specified by categories: actions, pedit,
> raw_op, layered_op. RAW_OP cases check offset option for u8, u16 and u32
> offset size. LAYERED_OP cases check fields option for eth, ip, ip6,
> tcp and udp headers.

Thanks Dmytro, the tests look pretty complete.  I like seeing all the
options exercised even if the impact is low.

Unless someone has an objection to any of the commands being tested
(i.e. doesn't make sense) I'd say go ahead and submit.

Thanks,

Lucas

>
> Include following tests:
> 377e - Add pedit action with RAW_OP offset u32
> a0ca - Add pedit action with RAW_OP offset u32 (INVALID)
> dd8a - Add pedit action with RAW_OP offset u16 u16
> 53db - Add pedit action with RAW_OP offset u16 (INVALID)
> 5c7e - Add pedit action with RAW_OP offset u8 add value
> 2893 - Add pedit action with RAW_OP offset u8 quad
> 3a07 - Add pedit action with RAW_OP offset u8-u16-u8
> ab0f - Add pedit action with RAW_OP offset u16-u8-u8
> 9d12 - Add pedit action with RAW_OP offset u32 set u16 clear u8 invert
> ebfa - Add pedit action with RAW_OP offset overflow u32 (INVALID)
> f512 - Add pedit action with RAW_OP offset u16 at offmask shift set
> c2cb - Add pedit action with RAW_OP offset u32 retain value
> 86d4 - Add pedit action with LAYERED_OP eth set src & dst
> c715 - Add pedit action with LAYERED_OP eth set src (INVALID)
> ba22 - Add pedit action with LAYERED_OP eth type set/clear sequence
> 5810 - Add pedit action with LAYERED_OP ip set src & dst
> 1092 - Add pedit action with LAYERED_OP ip set ihl & dsfield
> 02d8 - Add pedit action with LAYERED_OP ip set ttl & protocol
> 3e2d - Add pedit action with LAYERED_OP ip set ttl (INVALID)
> 31ae - Add pedit action with LAYERED_OP ip ttl clear/set
> 486f - Add pedit action with LAYERED_OP ip set duplicate fields
> e790 - Add pedit action with LAYERED_OP ip set ce, df, mf, firstfrag, nofrag fields
> 6829 - Add pedit action with LAYERED_OP beyond ip set dport & sport
> afd8 - Add pedit action with LAYERED_OP beyond ip set icmp_type & icmp_code
> 3143 - Add pedit action with LAYERED_OP beyond ip set dport (INVALID)
> fc1f - Add pedit action with LAYERED_OP ip6 set src & dst
> 6d34 - Add pedit action with LAYERED_OP ip6 dst retain value (INVALID)
> 6f5e - Add pedit action with LAYERED_OP ip6 flow_lbl
> 6795 - Add pedit action with LAYERED_OP ip6 set payload_len, nexthdr, hoplimit
> 1442 - Add pedit action with LAYERED_OP tcp set dport & sport
> b7ac - Add pedit action with LAYERED_OP tcp sport set (INVALID)
> cfcc - Add pedit action with LAYERED_OP tcp flags set
> 3bc4 - Add pedit action with LAYERED_OP tcp set dport, sport & flags fields
> f1c8 - Add pedit action with LAYERED_OP udp set dport & sport
> d784 - Add pedit action with mixed RAW/LAYERED_OP #1
> 70ca - Add pedit action with mixed RAW/LAYERED_OP #2