netdev - Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 10:41:54 +0800
From:   谢欢 <chongguiguzi@...il.com>
To:     Pkshih <pkshih@...ltek.com>
Cc:     "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet

Thank you so much for your useful advice.

Pkshih <pkshih@...ltek.com> 于2019年3月20日周三 上午10:31写道：
>
> On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@...il.com>
> >
> > ---
> >  drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > index 48ca521..4055e0a 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw
> > *hw)
> >
> >                       memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
> >
> > -                     spin_lock_bh(&rtlpriv->locks.waitq_lock);
> > +                     spin_lock(&rtlpriv->locks.waitq_lock);
> >                       if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> >                           (ring->entries - skb_queue_len(&ring->queue) >
> >                            rtlhal->max_earlymode_num)) {
> >                               skb = skb_dequeue(&mac->skb_waitq[tid]);
> >                       } else {
> > -                             spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > +                             spin_unlock(&rtlpriv->locks.waitq_lock);
> >                               break;
> >                       }
> > -                     spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > +                     spin_unlock(&rtlpriv->locks.waitq_lock);
> >
> >                       /* Some macaddr can't do early mode. like
> >                        * multicast/broadcast/no_qos data
>
> The mail subject should be 'rtlwifi: move ....', and the other looks good to me.
>
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
>
>