netdev - RE: regression from: net: phy: marvell: Avoid unnecessary soft reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 12:22:58 +0000
From:   liweihang <liweihang@...ilicon.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Phil Reid <preid@...ctromag.com.au>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        "dongsheng.wang@...-semitech.com" <dongsheng.wang@...-semitech.com>,
        "cphealy@...il.com" <cphealy@...il.com>,
        "clemens.gruber@...ruber.com" <clemens.gruber@...ruber.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "nbd@....name" <nbd@....name>,
        "harini.katakam@...inx.com" <harini.katakam@...inx.com>
Subject: RE: regression from: net: phy: marvell: Avoid unnecessary soft reset



> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@...il.com]
> Sent: Wednesday, March 20, 2019 11:37 AM
> To: liweihang <liweihang@...ilicon.com>; Phil Reid
> <preid@...ctromag.com.au>; netdev@...r.kernel.org
> Cc: Andrew Lunn <andrew@...n.ch>; David S. Miller
> <davem@...emloft.net>; dongsheng.wang@...-semitech.com;
> cphealy@...il.com; clemens.gruber@...ruber.com; hkallweit1@...il.com;
> nbd@....name; harini.katakam@...inx.com
> Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset
> 
> 
> 
> On 3/19/2019 7:34 PM, liweihang wrote:
> > Hi all,
> >
> > I've met a similar issue and sent an email to discuss about it before:
> > Question about setting speed and duplex failed after auto-negotiation
> > disabled on marvell phy
> >
> > d6ab93364734 net: phy: marvell: Avoid unnecessary soft reset I
> > reverted this patch and the auto-negotiation works ok.
> >
> > Florian, could you please read my previous email and give me some advice?
> 
> If you can copy the patch author on that email the next time that will help
> expedite things.
> 
> So the problem seems to come from the fact that unless the BCMR_RESET bit
> is written, then m88e1121_config_aneg_rgmii_delays() has no effect, does
> that sound like what you are observing?
> 
> Does the following work for you (Phil and yourself)?

Thank you, Florian. But that didn't work for me either. I think the key question is
as what Heiner said, some bits need to be preserved.

The MII_BMCR contained information of speed and duplex mode, but when we 
call genphy_soft_reset(), these bits will be cleared.

> 
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index
> 3ccba37bd6dd..6a1ea4c2042a 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -448,6 +448,10 @@ static int m88e1121_config_aneg(struct phy_device
> *phydev)
>                 err = m88e1121_config_aneg_rgmii_delays(phydev);
>                 if (err < 0)
>                         return err;
> +
> +               err = genphy_soft_reset(phydev);
> +               if (err < 0)
> +                       return err;
>         }
> 
>         err = marvell_set_polarity(phydev, phydev->mdix_ctrl);
>