netdev - Re: [patch net-next 09/11] dsa: move devlink_port_attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321134414.GG2087@nanopsycho>
Date:   Thu, 21 Mar 2019 14:44:14 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        idosch@...lanox.com, jakub.kicinski@...ronome.com,
        f.fainelli@...il.com, vivien.didelot@...il.com
Subject: Re: [patch net-next 09/11] dsa: move devlink_port_attrs_set() call
 before register

Thu, Mar 21, 2019 at 02:41:01PM CET, andrew@...n.ch wrote:
>On Thu, Mar 21, 2019 at 02:20:17PM +0100, Jiri Pirko wrote:
>> +	switch (dp->type) {
>> +	case DSA_PORT_TYPE_CPU:
>> +		flavour = DEVLINK_PORT_FLAVOUR_CPU;
>> +		break;
>> +	case DSA_PORT_TYPE_DSA:
>> +		flavour = DEVLINK_PORT_FLAVOUR_DSA;
>> +		break;
>> +	case DSA_PORT_TYPE_USER: /* fall-through */
>> +	default:
>> +		flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
>> +		break;
>> +	}
>> +
>> +	/* dp->index is used now as port_number. However
>> +	 * CPU ports should have separate numbering
>> +	 * independent from front panel port numbers.
>> +	 */
>
>Hi Jiri
>
>Given the way you have rearranged this code, i think the text above
>should now be:
>
>However CPU ports and DSA ports should have separate numbering.

You are right. Will fix in v2.

>
>	Andrew