netdev - Re: [PATCH net-next v4 05/22] ethtool: introduce ethtool netlink interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321135705.GB17655@lunn.ch>
Date:   Thu, 21 Mar 2019 14:57:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 05/22] ethtool: introduce ethtool netlink
 interface

On Thu, Mar 21, 2019 at 02:07:35PM +0100, Michal Kubecek wrote:
> +static int __init ethnl_init(void)
> +{
> +	int ret;
> +
> +	ret = genl_register_family(&ethtool_genl_family);
> +	if (ret < 0)
> +		panic("ethtool: could not register genetlink family\n");

Hi Michal

Panic seems a bit strong. Do we really want to kill the box because
this fails?

     Andrew