netdev - Re: [PATCH net-next v3 12/12] net: sched: flower: set unlocked flag for flower proto ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190321141314.GP2087@nanopsycho>
Date:   Thu, 21 Mar 2019 15:13:14 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, sbrivio@...hat.com
Subject: Re: [PATCH net-next v3 12/12] net: sched: flower: set unlocked flag
 for flower proto ops

Thu, Mar 21, 2019 at 02:17:44PM CET, vladbu@...lanox.com wrote:
>Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its
>ops callbacks don't require caller to hold rtnl lock. Don't take rtnl lock
>in fl_destroy_filter_work() that is executed on workqueue instead of being
>called by cls API and is not affected by setting
>TCF_PROTO_OPS_DOIT_UNLOCKED. Rtnl mutex is still manually taken by flower
>classifier before calling hardware offloads API that has not been updated
>for unlocked execution.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>