netdev - Re: [PATCH bpf-next] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190321032714.7cnzxmuqb3jhu4zr@ast-mbp.dhcp.thefacebook.com>
Date:   Wed, 20 Mar 2019 20:27:15 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Peter Oskolkov <posk@...gle.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Lawrence Brakmo <brakmo@...com>,
        Peter Oskolkov <posk@...k.io>
Subject: Re: [PATCH bpf-next] bpf: make bpf_skb_ecn_set_ce callable from
 BPF_PROG_TYPE_SCHED_ACT

On Wed, Mar 20, 2019 at 12:06:40AM -0700, Peter Oskolkov wrote:
> This helper is useful if a bpf tc filter sets skb->tstamp.
> 
> Signed-off-by: Peter Oskolkov <posk@...gle.com>
> ---
>  net/core/filter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 647c63a7b25b..c6d016d9c4b8 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -5719,6 +5719,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
>  		return &bpf_tcp_sock_proto;
>  	case BPF_FUNC_get_listener_sock:
>  		return &bpf_get_listener_sock_proto;
> +	case BPF_FUNC_skb_ecn_set_ce:
> +		return &bpf_skb_ecn_set_ce_proto;

makes sense, but I would like to see a selftest that it was tested properly.