netdev - RE: [PATCH net] dpaa2-eth: Fix possible access beyond end of array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 15:26:27 +0000
From:   Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ioana Ciornei <ioana.ciornei@....com>,
        "brouer@...hat.com" <brouer@...hat.com>
Subject: RE: [PATCH net] dpaa2-eth: Fix possible access beyond end of array

> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Thursday, March 21, 2019 1:29 AM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
> Cc: netdev@...r.kernel.org; Ioana Ciornei <ioana.ciornei@....com>;
> brouer@...hat.com
> Subject: Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array
> 
> From: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
> Date: Wed, 20 Mar 2019 14:11:04 +0000
> 
> > Make sure we don't try to enqueue XDP_REDIRECT frames to an
> > inexistent FQ.
> >
> > While it is guaranteed not to have more than one queue per core,
> > having fewer queues than CPUs on an interface is a valid
> > configuration.
> >
> > Fixes: d678be1dc1ec ("dpaa2-eth: add XDP_REDIRECT support")
> > Reported-by: Jesper Dangaard Brouer <brouer@...hat.com>
> > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@....com>
> 
> Applied, thanks.
> 
> I hope the modulus operation doesn't start showing up on profiles.

I haven't seen any performance impact on XDP_REDIRECT numbers.

Also, I think this patch should be added to stable as well, the bug it
fixes is quite ugly.

Thanks,
Ioana