netdev - Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f2160f2-28f1-bd61-86ee-3db77fd67ba4@gmail.com>
Date:   Thu, 21 Mar 2019 11:26:08 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Marek Behún <marek.behun@....cz>,
        netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Michal Vokáč <vokac.m@...il.com>,
        John Crispin <john@...ozen.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Christian Lamparter <chunkeey@...il.com>
Subject: Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO
 address

+Christian,

On 3/21/19 11:23 AM, Marek Behún wrote:
> The MDIO addresses of the internal PHYs on this switch for ports 1-5
> have addresses 0-4, not 1-5.
> 

Can you provide a Fixes: tag for this? Your change will conflicts with
Christian's patch series here:

http://patchwork.ozlabs.org/project/netdev/list/?series=98063

> Signed-off-by: Marek Behún <marek.behun@....cz>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Michal Vokáč <vokac.m@...il.com>
> Cc: John Crispin <john@...ozen.org>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/net/dsa/qca8k.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index cdcde7f8e0b2..eb199193cc3b 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -625,7 +625,7 @@ qca8k_phy_read(struct dsa_switch *ds, int phy, int regnum)
>  {
>  	struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
>  
> -	return mdiobus_read(priv->bus, phy, regnum);
> +	return mdiobus_read(priv->bus, phy - 1, regnum);
>  }
>  
>  static int
> @@ -633,7 +633,7 @@ qca8k_phy_write(struct dsa_switch *ds, int phy, int regnum, u16 val)
>  {
>  	struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
>  
> -	return mdiobus_write(priv->bus, phy, regnum, val);
> +	return mdiobus_write(priv->bus, phy - 1, regnum, val);
>  }
>  
>  static void
> 


-- 
Florian