netdev - Re: [PATCH net-next] fou: Support binding FoU socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190321.131000.1470414385607956803.davem@davemloft.net>
Date:   Thu, 21 Mar 2019 13:10:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kristian.evensen@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] fou: Support binding FoU socket

From: Kristian Evensen <kristian.evensen@...il.com>
Date: Wed, 20 Mar 2019 09:25:28 +0100

> The lookups performed when we add, delete or get an FoU-socket has also
> been updated to compare all the attributes a user can set. Since the
> comparison now involves several elements, I have added a separate
> comparison-function instead of open-coding.

This seems to allow adding both a wildcarded and a non-wildcarded fou
socket, which otherwise has overlapping match scenerios.

I don't think you want to allow that unless you can determine that
you aren't creating a situation where multiple fou sockets could
match the same tunneled packet.