netdev - Re: [PATCH 1/2] tun: Add ioctl() TUNGETDEVNETNS cmd to allow obtaining real net ns of tun device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190321.131927.1229577878872009929.davem@davemloft.net>
Date:   Thu, 21 Mar 2019 13:19:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ktkhai@...tuozzo.com
Cc:     netdev@...r.kernel.org, harald.albrecht@....net,
        jasowang@...hat.com, brouer@...hat.com, edumazet@...gle.com,
        mst@...hat.com, nicolas.dichtel@...nd.com, wangli39@...du.com
Subject: Re: [PATCH 1/2] tun: Add ioctl() TUNGETDEVNETNS cmd to allow
 obtaining real net ns of tun device

From: Kirill Tkhai <ktkhai@...tuozzo.com>
Date: Wed, 20 Mar 2019 12:16:42 +0300

> In commit f2780d6d7475 "tun: Add ioctl() SIOCGSKNS cmd to allow
> obtaining net ns of tun device" it was missed that tun may change
> its net ns, while net ns of socket remains the same as it was
> created initially. SIOCGSKNS returns net ns of socket, so it is
> not suitable for obtaining net ns of device.
> 
> We may have two tun devices with the same names in two net ns,
> and in this case it's not possible to determ, which of them
> fd refers to (TUNGETIFF will return the same name).
> 
> This patch adds new ioctl() cmd for obtaining net ns of a device.
> 
> Reported-by: Harald Albrecht <harald.albrecht@....net>
> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>

Applied.