netdev - Re: [v3 PATCH] rhashtable: Still do rehash when we get EEXIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190321.135814.680505348166965154.davem@davemloft.net>
Date:   Thu, 21 Mar 2019 13:58:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     joshhunt00@...il.com, jelsasser@...neta.com, tgraf@...g.ch,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v3 PATCH] rhashtable: Still do rehash when we get EEXIST

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 21 Mar 2019 09:39:52 +0800

> As it stands if a shrink is delayed because of an outstanding
> rehash, we will go into a rescheduling loop without ever doing
> the rehash.
> 
> This patch fixes this by still carrying out the rehash and then
> rescheduling so that we can shrink after the completion of the
> rehash should it still be necessary.
> 
> The return value of EEXIST captures this case and other cases
> (e.g., another thread expanded/rehashed the table at the same
> time) where we should still proceed with the rehash.
> 
> Fixes: da20420f83ea ("rhashtable: Add nested tables")
> Reported-by: Josh Elsasser <jelsasser@...neta.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied and queued up for -stable, thanks Herbert.