netdev - Re: [PATCH 6/7] net/core: Declare a local function 'static'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8a332e5-ce6e-a882-4ef2-4334a159fbeb@grimberg.me>
Date:   Thu, 21 Mar 2019 15:25:07 -0700
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Bart Van Assche <bvanassche@....org>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 6/7] net/core: Declare a local function 'static'

This can be dropped. Dave merged a fix for it already

On 3/21/19 3:19 PM, Bart Van Assche wrote:
> This patch avoids that the compiler complains about a missing prototype
> when building with W=1.
> 
> Cc: Sagi Grimberg <sagi@...mberg.me>
> Cc: Christoph Hellwig <hch@....de>
> Signed-off-by: Bart Van Assche <bvanassche@....org>
> ---
>   net/core/datagram.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/net/core/datagram.c b/net/core/datagram.c
> index c42f1f0e62b6..334e0a7ce940 100644
> --- a/net/core/datagram.c
> +++ b/net/core/datagram.c
> @@ -410,6 +410,7 @@ int skb_kill_datagram(struct sock *sk, struct sk_buff *skb, unsigned int flags)
>   }
>   EXPORT_SYMBOL(skb_kill_datagram);
>   
> +static
>   int __skb_datagram_iter(const struct sk_buff *skb, int offset,
>   			struct iov_iter *to, int len, bool fault_short,
>   			size_t (*cb)(const void *, size_t, void *, struct iov_iter *),
>