netdev - RE: [PATCH net-next 0/2] qed* enhancements.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR18MB12533B9B4FAE0A746A656EA5D3420@CY4PR18MB1253.namprd18.prod.outlook.com>
Date:   Thu, 21 Mar 2019 04:53:47 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        Michal Kalderon <mkalderon@...vell.com>
Subject: RE: [PATCH net-next 0/2] qed* enhancements.


> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Wednesday, March 20, 2019 11:44 PM
> To: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Cc: netdev@...r.kernel.org; Ariel Elior <aelior@...vell.com>; Michal
> Kalderon <mkalderon@...vell.com>
> Subject: Re: [PATCH net-next 0/2] qed* enhancements.
> 
> From: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Date: Wed, 20 Mar 2019 00:26:24 -0700
> 
> > The patch series adds couple of enhancements for qed/qede drivers.
> > Please consider applying it to 'net-next' tree.
> >
> > Sudarsana Reddy Kalluru (2):
> >   qede: Populate mbi version in ethtool driver query data.
> >   qed: Define new MF bit for no_vlan config
> 
> Series appied.
> 
> I don't know how big your MBI version strings are, but if you are printing now
> both it and the MFW versions into that one string you might hit the
> ETHTOOL_FWVERS_LEN limit often.
> 
> Just a thought...

Dave,
   Thanks for your comments and accepting the changes. Size of mbi version string is 7 bytes and the mfw is 10 bytes. Hence the total string size including the spaces would be under ETHTOOL_FWVERS_LEN.

Thanks,
Sudarsana