netdev - Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <771238ae-6e47-cac2-7dfe-f44475e90e43@gmail.com>
Date:   Thu, 21 Mar 2019 01:58:41 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Jon Maloy <jon.maloy@...csson.com>,
        Ying Xue <ying.xue@...driver.com>,
        Hoang Le <hoang.h.le@...tech.com.au>
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] tipc: fix return value check in
 tipc_mcast_send_sync()



On 03/21/2019 01:58 AM, Wei Yongjun wrote:
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
> 
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  net/tipc/bcast.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 5264a8ff6e01..a41c0fa9c650 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
>  
>  	/* Allocate dummy message */
>  	_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> -	if (!skb)
> +	if (!_skb)
>  		return -ENOMEM;
>  
>  	/* Preparing for 'synching' header */
> 
> 
> 

Thanks for the patch, but some 'Reported-by:' tags are missing :/