netdev - Re: [patch net-next 02/11] bnxt: add missing net/devlink.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190322133850.GC2211@nanopsycho>
Date:   Fri, 22 Mar 2019 14:38:50 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, mlxsw@...lanox.com,
        idosch@...lanox.com, Jakub Kicinski <jakub.kicinski@...ronome.com>,
        f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [patch net-next 02/11] bnxt: add missing net/devlink.h include

Fri, Mar 22, 2019 at 10:16:34AM CET, vasundhara-v.volam@...adcom.com wrote:
>On Thu, Mar 21, 2019 at 6:50 PM Jiri Pirko <jiri@...nulli.us> wrote:
>>
>> From: Jiri Pirko <jiri@...lanox.com>
>>
>> devlink functions are in use, so include the related header file.
>>
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>> ---
>>  drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>> index e1feb97bcd81..ecb328ee8f5c 100644
>> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>> @@ -9,6 +9,7 @@
>>
>>  #include <linux/pci.h>
>>  #include <linux/netdevice.h>
>> +#include <net/devlink.h>
>Jiri,
>This net/devlink.h file is already included in bnxt.h file which is
>included in bnxt_devlink.c.
>Do you face any issues with existing code while compiling or testing?

It is better to include directly, not to rely on some header to include
it.

>
>Thanks,
>Vasundhara
>
>
>>  #include "bnxt_hsi.h"
>>  #include "bnxt.h"
>>  #include "bnxt_vfr.h"
>> --
>> 2.17.2
>>