netdev - Re: [PATCH net-next 1/3] net: convert rps_needed and rfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Mar 2019 00:01:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Florian Westphal <fw@...len.de>,
        Tom Herbert <tom@...bertland.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 1/3] net: convert rps_needed and rfs_needed to
 new static branch api

Hi Eric,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-convert-rps_needed-and-rfs_needed-to-new-static-branch-api/20190322-211954
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers//net/tun.c: In function 'tun_automq_xmit':
>> drivers//net/tun.c:1045:46: error: passing argument 1 of 'static_key_false' from incompatible pointer type [-Werror=incompatible-pointer-types]
     if (tun->numqueues == 1 && static_key_false(&rps_needed)) {
                                                 ^~~~~~~~~~~
   In file included from include/linux/module.h:19,
                    from drivers//net/tun.c:44:
   include/linux/jump_label.h:259:65: note: expected 'struct static_key *' but argument is of type 'struct static_key_false *'
    static __always_inline bool static_key_false(struct static_key *key)
                                                 ~~~~~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors

vim +/static_key_false +1045 drivers//net/tun.c

^1da177e Linus Torvalds 2005-04-16  1040  
^1da177e Linus Torvalds 2005-04-16  1041  /* Net device start xmit */
96f84061 Jason Wang     2017-12-04  1042  static void tun_automq_xmit(struct tun_struct *tun, struct sk_buff *skb)
^1da177e Linus Torvalds 2005-04-16  1043  {
3df97ba8 Jason Wang     2016-04-25  1044  #ifdef CONFIG_RPS
96f84061 Jason Wang     2017-12-04 @1045  	if (tun->numqueues == 1 && static_key_false(&rps_needed)) {
9bc88939 Tom Herbert    2013-12-22  1046  		/* Select queue was not called for the skbuff, so we extract the
9bc88939 Tom Herbert    2013-12-22  1047  		 * RPS hash and save it into the flow_table here.
9bc88939 Tom Herbert    2013-12-22  1048  		 */
4b035271 Wang Li        2018-10-09  1049  		struct tun_flow_entry *e;
9bc88939 Tom Herbert    2013-12-22  1050  		__u32 rxhash;
9bc88939 Tom Herbert    2013-12-22  1051  
feec084a Jason Wang     2017-06-06  1052  		rxhash = __skb_get_hash_symmetric(skb);
4b035271 Wang Li        2018-10-09  1053  		e = tun_flow_find(&tun->flows[tun_hashfn(rxhash)], rxhash);
9bc88939 Tom Herbert    2013-12-22  1054  		if (e)
9bc88939 Tom Herbert    2013-12-22  1055  			tun_flow_save_rps_rxhash(e, rxhash);
9bc88939 Tom Herbert    2013-12-22  1056  	}
3df97ba8 Jason Wang     2016-04-25  1057  #endif
96f84061 Jason Wang     2017-12-04  1058  }
96f84061 Jason Wang     2017-12-04  1059  

:::::: The code at line 1045 was first introduced by commit
:::::: 96f84061620c6325a2ca9a9a05b410e6461d03c3 tun: add eBPF based queue selection method

:::::: TO: Jason Wang <jasowang@...hat.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (53125 bytes)